fix(cli): accept URL value for --git-ref option#767
fix(cli): accept URL value for --git-ref option#767Sahilshrma31 wants to merge 1 commit intonodejs:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 604ec8e. Bugbot is set up for automated code reviews on this repo. Configure here. |
avivkeller
left a comment
avivkeller
left a comment
There was a problem hiding this comment.
I don't think it's supposed to take a URL
thanks for the feedback. my reasoning was based on consistency with nearby options like --changelog , --index , and --type-map , and their descriptions mentioning “url or path.” seeing --git-ref next to those made me interpret it similarly, so i updated it to accept |
2 participants
Description
Fixes a CLI argument parsing issue where the
--git-refoption was incorrectly defined as a flag instead of accepting a value.The option is intended to take a URL (as indicated by its description), but its previous definition caused the CLI to throw an error when a value was passed. This change updates the option to correctly accept a value.
Validation
Before:
Running the CLI with a value for
--git-reffails because the option is incorrectly parsed as a boolean flag instead of accepting a value.After:
The
--git-refoption is now correctly parsed as a value option, allowing a URL to be passed without causing argument parsing errors.Related Issues
N/A
Check List
node --run testand all tests passed.node --run format&node --run lint.